[cxx-interop] Support conforming to protocols with default assoc types #83461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the type does not define a type alias with the same name fall back to the default type of the associated type in the protocol. Previously, the compiler crashed. Unfortunately, we are still crashing when we do not find the right conformance. In a follow-up PR I plan to add more graceful handling of the case when the lookup fails. rdar://154098495
Xazax-hun
requested review from
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the type does not define a type alias with the same name fall back to the default type of the associated type in the protocol. Previously, the compiler crashed.
Unfortunately, we are still crashing when we do not find the right conformance. In a follow-up PR I plan to add more graceful handling of the case when the lookup fails.
rdar://154098495